PHP8.4 Warning in report.php

[Tapio]

Upgrading to PHP8.4 gives a warning in report.php-file:
"Deprecated: fgetcsv(): the $escape parameter must be provided as its default value will change in ...\report.php on line 542"

[David]

Change line 542 in report.php:

Old line:

while (($data[$row] = fgetcsv($handle, 0, ",")) !== FALSE)

New line:

while (($data[$row] = fgetcsv($handle, 0, ",", '"', "\\")) !== FALSE)

[Tapio]

Thanks, this corrected the report.php file.

Then, for curiosity, I also tested the compatibility in PHP 8.5, and got a new warning:
"Deprecated: Non-canonical cast (double) is deprecated, use the (float) cast instead in ... \search.php on line 1826"

In this line I tried to change the word '(double)' to '(float)', which seemed to work. But is that the correct measure and sufficient for the fix?

[David]

Yes, this change to (float) is fine.

They mean exactly the same thing in PHP. Both float and double are 64bit precision floating point numbers. They've been interchangeable for years, but now PHP is cleaning up the syntax to only have one key word for this.